[FFmpeg-devel] [PATCH] Fixed PNG decoding with Paeth filter for RGBA 64-bits.

Christophe Gisquet christophe.gisquet at gmail.com
Fri Dec 5 10:29:49 CET 2014


Hi,

2014-12-05 1:20 GMT+01:00 Dominique Leroux <Dominique.Leroux at autodesk.com>:
> Found and fixed an artifact in the last column of decoded RGBA 64-bits PNG images.
>
> The code was dealing with a SIMD-optimized version of the function without taking into account that we can have RGB/RGBA images that are respectively 6 or 8  bytes per pixel (not just 3 or 4).

First, what version are you working on? Ronald included a fix in
http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=af79a0c48a41fd99b674b39ac509ae442974715d
that would then be incomplete?

If true, then it probably means we don't have a "fate" test for it (ie
a means to validate ffmpeg's output against a known "good"
checksum/behaviour), or that it is unaffected by the bug.

In any case, could you share a sample file exhibiting the issue? I
guess cropping to the last few lines would be fine from a quick glance
at your patch. But I haven't studied the issue to actually validate
it.

Thank you,
-- 
Christophe


More information about the ffmpeg-devel mailing list