[FFmpeg-devel] [PATCH] libavfilter: unsharpen opencl filter optimizations

[Christophe Gisquet]

Hi,

Le 19 déc. 2014 07:28, "Titov, Alexey" <Alexey.Titov at amd.com> a écrit :
>
> Hi Michael,
>
> Here is the patch. I attached a zip of this patch in the last email, but
it was probably stripped off.
> Let me know how I can help.
[...]
> diff --git a/libavutil/opencl.c b/libavutil/opencl.c
> index 36cb6fe..738d0db 100644
> --- a/libavutil/opencl.c
> +++ b/libavutil/opencl.c
> @@ -450,7 +450,24 @@ cl_program av_opencl_compile(const char
*program_name, const char *build_opts)
>      status = clBuildProgram(program, 1, &(opencl_ctx.device_id),
build_opts, NULL, NULL);
>      if (status != CL_SUCCESS) {
>          av_log(&opencl_ctx, AV_LOG_ERROR,
> -               "Compilation failed with OpenCL program: %s\n",
program_name);
> +            "Compilation failed with OpenCL program: '%s' with error %d
\n", program_name, status);
> +
> +        // Determine the size of the log
> +        size_t log_size;
> +        clGetProgramBuildInfo(program, &(opencl_ctx.device_id),
CL_PROGRAM_BUILD_LOG, 0, NULL, &log_size);
> +
> +        // Allocate memory for the log
> +        char *log = (char *) malloc(log_size+1);
> +
> +        // Get the log
> +        clGetProgramBuildInfo(program, &(opencl_ctx.device_id),
CL_PROGRAM_BUILD_LOG, log_size, log, NULL);
> +        log[log_size] = '\0';
> +        printf("--- Build log ---\n ");
> +        // Print the log
> +        printf("%s\n", log);
> +        printf("--- End Build log ---\n ");
> +
> +        free(log);
>          program = NULL;
>          goto end;
>      }
> --
> 1.8.4.msysgit.0

Without knowing anything about opencl, I'd say this hunk would better be a
separate patch.

Second, I guess this compile log could be a huge output, furthermore on
stdout. Using stderr would be better, and no idea about how to deal with
the 'huge' part.

Sent from a phone so please excuse terseness.