[FFmpeg-devel] [PATCH] RoQ-encoder: introducing Quake 3 compatibility option

[Clément Bœsch]

On Sat, Feb 01, 2014 at 02:38:08PM +0000, u-owvm at aetey.se wrote:
> As an afterthought:
> following the principle of least surprise the option default
> should be "compatibility", in other words
> 
> +static const AVOption options[] = {
> +    { "quake3_compat", "Whether to respect known bugs in Quake 3 decoder", OFFSET(quake3_compat), AV_OPT_TYPE_INT, { .i64 = 1 }, 0, 1, VE },
> -----------------------------------------------------------------------------------------------------------------------------^
> 
> instead of
> 
> > +static const AVOption options[] = {
> > +    { "quake3_compat", "Whether to respect known bugs in Quake 3 decoder", OFFSET(quake3_compat), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, 1, VE },
> -------------------------------------------------------------------------------------------------------------------------------^
> 
> Reattaching the patch, with this one-bit change.
> 
> Yours,
> Rl

> From b906a2fc2c4dd46f9629131c4c1e4b8c5629ca46 Mon Sep 17 00:00:00 2001
> From: Rl <addr-see-the-website at aetey.se>
> Date: Fri, 31 Jan 2014 20:06:15 +0100
> Subject: [PATCH 2/3] RoQ-encoder: introducing Quake 3 compatibility option
> 
> ---
>  libavcodec/roqvideo.h    |    4 ++++
>  libavcodec/roqvideoenc.c |   30 +++++++++++++++++++++++-------
>  2 files changed, 27 insertions(+), 7 deletions(-)
> 
[...]
> +#define OFFSET(x) offsetof(RoqContext, x)
> +#define VE AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM
> +static const AVOption options[] = {
> +    { "quake3_compat", "Whether to respect known bugs in Quake 3 decoder", OFFSET(quake3_compat), AV_OPT_TYPE_INT, { .i64 = 1 }, 0, 1, VE },

Just curious; isn't ioquake3 opensource? Can't you submit a bugfix there
instead?

Otherwise, if it's a feature limitation, the description shouldn't mention
"bugs".

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140201/90d39d94/attachment.asc>