[FFmpeg-devel] [PATCH] http: handle URLs with spaces

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Feb 2 19:20:28 CET 2014


On 02.02.2014, at 19:12, Nicolas George <george at nsup.org> wrote:
> Le quartidi 14 pluviôse, an CCXXII, wm4 a écrit :
>> I'm not sure what's the advantage of having libavformat send malformed
>> HTTP requests to the server when we could trivially send a correct one.
> 
> I already said that I considered the proper behaviour to be to reject
> invalid URLs with EINVAL.

From my point of view this would be acceptable.
Though personally I am always in favour of making things as easy to use and resilient as possible, but also make it possible to detect errors.
Which means why personal favourite would be to just escape the invalid characters (which IMHO is not surprising behaviour since that is what many, if not most, programs do), but also warn about it, and return EINVALID if strict is set to conformant or higher (though there I admit there is some issue in applying "strict" to user input/API input instead of just the processed content).


More information about the ffmpeg-devel mailing list