[FFmpeg-devel] [PATCH 1/3] lavfi/ebur128: add sample and true peak metering.
u at pkh.me
Sun Feb 2 20:54:49 CET 2014
On Fri, Jan 31, 2014 at 09:16:55AM +0100, Clément Bœsch wrote:
> On Sat, Jan 25, 2014 at 11:19:05PM +0100, Jean First wrote:
> > From: Clément Bœsch <ubitux at gmail.com>
> > Metadata injection and logging. Not yet present visually.
> > Signed-off-by: Jean First <jeanfirst at gmail.com>
> > ---
> > doc/filters.texi | 21 ++++++++
> > libavfilter/f_ebur128.c | 140 +++++++++++++++++++++++++++++++++++++++++++-----
> > 2 files changed, 149 insertions(+), 12 deletions(-)
> So IIRC, the two main standing issues with this patch are the peaks not
> expressed in dBFS - which you fixed in a later commit -, and the potential
> build problem because of FFLIBS lacking swresample in libavfilter/Makefile
> for this particular filter. The trick is that this dependency is optional,
> but if this filter and swr are enabled, FFLIBS needs a swresample
> reference. It should be relatively trivial to do, so I'll probably patch
> and push this week end.
Fixed FFLIBS and applied.
You might want to update the metadata ebur128 fate test to check these
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 490 bytes
Desc: not available
More information about the ffmpeg-devel