[FFmpeg-devel] [PATCH] http: handle URLs with spaces

Reimar Döffinger Reimar.Doeffinger at gmx.de
Mon Feb 3 08:49:53 CET 2014


On 03.02.2014, at 08:38, Eli Kara <eli at algotec.co.il> wrote:
> 
>> That is nonsense. You cannot break >anything by escaping only the >characters that would otherwise cause >a malformed http request - at least not >more that by changing it to return an >EINVALID.
>> In fact there is a chance you break it >less since some servers might just >accept invalid characters in an URL
> 
> If the encoding code is not intelligent enough, double encodes will result in unplayable URLs. Currently most everyone encode them. 

Could you please try actually reading what I wrote? There is no way encoding a space character can result in double encoding, period. It is _absolutely_ _impossible_ for that to break anything compared to now (assuming no server that actually wants broken URLs and assuming you're not trying to write server exploits...)


More information about the ffmpeg-devel mailing list