[FFmpeg-devel] [WIP] H.264 MVC decoder
u at pkh.me
Thu Feb 6 11:08:14 CET 2014
On Wed, Feb 05, 2014 at 05:13:00PM +0100, Gerion Entrup wrote:
> Am Mittwoch, 5. Februar 2014, 16:47:41 schrieb Clément Bsch:
> > On Wed, Feb 05, 2014 at 04:24:11PM +0100, Gerion Entrup wrote:
> > > Hello,
> > >
> > > I see you have MVC as a GSoC-project. There is an existing implementation,
> > > I found it recently as a master thesis . The original code you can
> > > find at github .
> > >
> > > I've cleaned it up (remove temporary files, reformat, ...), see the
> > > attached patch.
> > > The patch applies against commit 69cc119d (0.11.x release branch, I
> > > think),
> > > just like the original code. The code compiles, I have not tested it. If
> > > you like the code, I would try to merge it into master (but not until
> > > next month, feel free to do it earlier ;)). Please comment. I do not have
> > > the skills (yet?) to review the code quality-wise.
> > >
> > > The original author is CCed.
> > >
> > > Regards,
> > > Gerion
> > Your diff contains thousands of commented out lines. Drop them.
> Ok. The EDIT comments, too, I think?
> > Then you have tones of reindented lines. Restore the original indent, it
> > will be reindented in a later patch.
> I think, orginal author use eclipse formatting. I replace thousands of tabs
> with spaces for example. What do you mean with reindented lines and what is
> "original indent"? The indent of commit 69cc119d? I was sure to replace all
> reformatted indends of existing code.
Stuff like that:
- // reference lists
- copy_fields(h, h1, ref_count, list_count);
- copy_fields(h, h1, ref_list, intra_gb);
- copy_fields(h, h1, short_ref, cabac_init_idc);
+ // reference lists
+ copy_fields(h, h1, ref_count, list_count);
+ copy_fields(h, h1, ref_list, intra_gb);
+ copy_fields(h, h1, short_ref, cabac_init_idc);
Keep the indentation "wrong", and eventually add a "// FIXME: reindent" above.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 490 bytes
Desc: not available
More information about the ffmpeg-devel