[FFmpeg-devel] [PATCH 2/2] lavd/sdl: reset context variables after destroy

Nicolas George george at nsup.org
Fri Feb 7 17:01:01 CET 2014

Le nonidi 19 pluviôse, an CCXXII, Lukasz Marek a écrit :
> SDL device reports double free or hangs when quiting.
> Reseting variables solves the issue.

I am a bit unsure about this: it actually fixes the actual double frees, but
it still means someone is trying to free something they should not be
freeing; the issue is only hidden, and other symptoms may be present.

Did you investigate to find what part of the code does the second freeing?

Not that I object to the patch: not leaving loaded pointers is usually good
practice anyway. But maybe add a comment somewhere:

/* XXX someone is trying to free this twice */


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140207/a2d9f423/attachment.asc>

More information about the ffmpeg-devel mailing list