[FFmpeg-devel] [PATCH 2/2] lavd/sdl: reset context variables after destroy

Lukasz Marek lukasz.m.luki at gmail.com
Sat Feb 8 02:12:43 CET 2014

On 07.02.2014 17:08, Nicolas George wrote:
> Le nonidi 19 pluviôse, an CCXXII, Lukasz M a écrit :
>> Yes, I investigated.
>> write_trailer is called for the first time in write_packet when quit flag
>> is set.
>> Second write_trailer comes from ffmpeg.c
>> I was thinking about removing that call from write_packet too, seems
>> redundant.
> I see, thanks for explaining. I do not know whether this is redundant (there
> is unfortunately no common cleanup code for muxers, that would be called
> even when muxing fails), but it is clearly wanted and not a bug, and this
> patch is therefore necessary and correct.

That is possible. I remember the issue wasn't present when Stefano 
commited it, but started to occur recently. Maybe someone added some 
clean up code in the meantime.

> Maybe copy-paste this message to the commit message.

OK, attached.

Best Regards,
Lukasz Marek

If you can't explain it simply, you don't understand it well enough. - 
Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-lavd-sdl-reset-context-variables-after-destroy.patch
Type: text/x-patch
Size: 1300 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140208/b42ab43e/attachment.bin>

More information about the ffmpeg-devel mailing list