[FFmpeg-devel] [PATCH] lavfi: add dejudder filter to remove judder produced by partially telecined material.
lukasz.m.luki at gmail.com
Sun Feb 9 01:25:46 CET 2014
>>> + int64_t *ringbuff;
>>> + int a, b, c, d;
>> comments/doxy are welcome here, also "a, b, c, d" are not very
>> descriptive variable names.
> a--d are indexes to a ring buffer. I could name them "previous, second-previous, ultimate, penultimate" but that seemed cumbersome. Would a comment here about what they are be helpful?
maybe i1, i2, i3, i4 is better than a,b,c,d. At least it says they are
>>> +static int filter_frame(AVFilterLink *inlink, AVFrame *frame)
>>> + int i;
>>> + AVFilterContext *ctx = inlink->dst;
>>> + AVFilterLink *outlink = ctx->outputs;
>>> + DejudderContext *dj = ctx->priv;
>>> + int64_t *judbuff = dj->ringbuff;
>> you can probably remove the indirection and leave optims to the
> If I understand you, you are suggesting I replace all my judbuff's in the code with "inlink->dst->priv->ringbuff". This seems a little cumbersome. Is that what you mean? Other filters seem to do what I've done here.
I think Stefano referred the last one.
More information about the ffmpeg-devel