[FFmpeg-devel] [Bulk] Re: [PATCH] doc/filters/setsar: remove superfluous paragraph

Tim Nicholson nichot20 at yahoo.com
Tue Feb 11 09:20:26 CET 2014

On 10/02/14 21:12, Michael Niedermayer wrote:
> On Mon, Feb 10, 2014 at 05:57:15PM +0100, Werner Robitza wrote:
>> The same sentence appears two paragraphs before and is redundant.
>> ---
>>  doc/filters.texi | 4 ----
>>  1 file changed, 4 deletions(-)
>> diff --git a/doc/filters.texi b/doc/filters.texi
>> index 2639f8c..9184b50 100644
>> --- a/doc/filters.texi
>> +++ b/doc/filters.texi
>> @@ -7219,10 +7219,6 @@ Note that as a consequence of the application of this filter, the
>>  output display aspect ratio will change according to the equation
>>  above.
>> -Keep in mind that the sample aspect ratio set by the @code{setsar}
>> -filter may be changed by later filters in the filterchain, e.g. if
>> -another "setsar" or a "setdar" filter is applied.
>> -
>>  The filters accept the following options:
> I dont know what the intend was but it appears one of these paragraphs
> is about setdar, the other about setsar

I think the wording of the section is a little tautologous due to some
references specifically to setsar and others setdar, when in fact the
operational function of the filters is the same, the only difference
being which variables in the explanatory equation are defined, and which

IMHO it could be better worded but I would prefer tautology that ensures
no ambiguity rather than the reverse which I think this patch introduces.

> [...]


More information about the ffmpeg-devel mailing list