[FFmpeg-devel] [PATCH v2] Add libx265 encoder

Derek Buitenhuis derek.buitenhuis at gmail.com
Tue Feb 11 22:36:38 CET 2014


On 2/11/2014 9:29 PM, James Almer wrote:
> Missing general.texi changes for HEVC encoding.

Added locally.

>> +- libx265 encoder
> 
> nit: wrapper?

It's already implied by the 'lib' in libx265.

>> +    x265_param_default(ctx->params);
>> +    if (x265_param_default_preset(ctx->params, ctx->preset, ctx->tune) < 0)
>> +        av_log(avctx, AV_LOG_WARNING, "Invalid preset or tune.\n");
> 
> Shouldn't this return AVERROR(EINVAL) instead? We're currently doing that with libx264.
> Doesn't seem like a good idea proceeding with what could potentially be a big encoding 
> after the user typoed the preset/tune he wanted.

It's not strictly a fatal error IMO, but I'll go with whatever
the popular opinion is.

>> +static const AVOption options[] = {
>> +    { "preset",      "set the x265 preset",                                                        OFFSET(preset),    AV_OPT_TYPE_STRING, { 0 }, 0, 0, VE },
>> +    { "tune",        "set the x265 tune parameter",                                                OFFSET(tune),      AV_OPT_TYPE_STRING, { 0 }, 0, 0, VE },
>> +    { "x265-params", "set the x265 configuration using a :-separated list of key=value parameters", OFFSET(x265_opts), AV_OPT_TYPE_STRING, { 0 }, 0, 0, VE },
>> +    { NULL },
>> +};
> 
> nit: vertical alignment.

Fixed locally.

- Derek


More information about the ffmpeg-devel mailing list