[FFmpeg-devel] [PATCH 1/2] x86inc: Extend FMA_INSTR functionality

Christophe Gisquet christophe.gisquet at gmail.com
Fri Feb 14 09:57:40 CET 2014


2014-02-13 James Almer <jamrial at gmail.com>:
> You're right, a fifth parameter is probably the proper way. See
> FMULADD_PS in x86util. It would allow actual non-destructive emulation
> of these XOP instructions if it's ever needed.
> It's not for now, but changing it will not hurt and it will probably have
> to be done at some point anyway.

You can probably make it optional (haven't looked at FMULADD_PS), ie
make the macro use 4-8 arguments, and if %0 == 8, use %8, otherwise
use %2.

-- 
Christophe


More information about the ffmpeg-devel mailing list