[FFmpeg-devel] [PATCHv2 2/6] avcodec/vp8dsp: add VP7 idct and loop filter

Michael Niedermayer michaelni at gmx.at
Sat Feb 15 02:25:17 CET 2014


On Fri, Feb 14, 2014 at 07:13:08AM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Fri, Feb 14, 2014 at 6:58 AM, Peter Ross <pross at xvid.org> wrote:
> 
> > +static const int16_t vp7_dct_matrix[4][4] =
> > +{
> > +    { 23170,  30274,  23170,  12540 },
> > +    { 23170,  12540, -23170, -30274 },
> > +    { 23170, -12540, -23170,  30274 },
> > +    { 23170, -30274,  23170, -12540 }
> > +};
> >
> 
> Unused.
> 
> Rest looks OK.

applied

i wonder though if some of the if(!vp7) could be avoided by using
more seperate function pointers for vp7, but i didnt look at the code
using these ...

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140215/7a6e9cb3/attachment.asc>


More information about the ffmpeg-devel mailing list