[FFmpeg-devel] [PATCH 01/10] dcadsp: remove scaling in LFE FIR

[Christophe Gisquet]

Hi,

2014-02-14 23:19 GMT+01:00 Michael Niedermayer <michaelni at gmx.at>:
> I suggest instead of replacing the numeric values to instead use
> a macro like
> DECLARE_ALIGNED(16, static const float, lfe_fir_64)[] =
> {
>     LFE_FIR_SCALE(2.658434386830777e-4), LFE_FIR_SCALE(9.029330685734748e-3),
>     ...
>
> to do the scaling
> this way different scales can be used without the need to replace
> the whole table in the source

Indeed I'm not sure how much this was future-proof. I'm still not, in
particular if dtshd support requires a different handling.

Another point about this patch is that it requires changes in the arm
code (won't even compile).

-- 
Christophe