[FFmpeg-devel] [PATCH] set FONTCONFIG_PATH relative to ffmpeg binary, if it is a static build

[Reimar Döffinger]

On Mon, Feb 17, 2014 at 06:26:18AM -0500, Helmut Tessarek wrote:
> On 17.02.14 5:26 , Nicolas George wrote:
> > Thanks for the patch. It requires quite a few adjustments before being 
> > considered.
> 
> I gladly make the necessary adjustments, but it seems that Reimar doesn't
> think this patch is even necessary.

I think it's not a good idea with the dependency on static.
Changing build options IMHO is nothing that should change program
behaviour significantly.
Someone might be making a static build on their Linux machine because
they do not want to install the binary and building static is the
easiest way to make it work.
They wouldn't want fontconfig to create a new folder instead of using
the existing stuff because of that.
However I do for example see the use-case of someone having FFmpeg on
a USB stick and not wanting it to modify or use the local file system.
But that would then as I said require other changes, like not reading
the config file from $HOME.
It should probably also do some special rpath tricks so it works even
for non-static builds.
Such a change is something I think would be welcome and should include
a change like this.
But this specific implementation IMHO just doesn't make much sense.

> I thought it made sense, but I might be alone with this opinion. So how does
> this work? Are you guys going to discuss this at some internal ffmpeg
> developer meeting and call a vote?

We don't generally do internal discussions or votes, generally things
are applied when there are no objections, or people say they won't
block something despite objection because a large majority has voiced
their support.

> Please let me know what I should do. Shall I wait or change the code
> according to your comments?

That's up to you, every improvement makes it more likely to be accepted,
but I think the biggest issue is to figure out based on which condition
this code should be enabled.