[FFmpeg-devel] [PATCH] set FONTCONFIG_PATH relative to ffmpeg binary, if it is a static build

Helmut Tessarek tessarek at evermeet.cx
Mon Feb 17 13:39:25 CET 2014


Thanks for your answers.

On 17.02.14 6:55 , Reimar Döffinger wrote:
> That's up to you, every improvement makes it more likely to be accepted,
> but I think the biggest issue is to figure out based on which condition
> this code should be enabled.

I agree that my condition is not optimal and I like your idea of a new
configure option. I should have thought of it, but my patch was rather a quick
hack to see what people think.

--enable-portable[=path]
--enable-rel-fc-path[=path]
--enable-relative-fontconfig-path[=path]

I like your --enable-portable, since it is shorter than the others, although
it is quite generic.

I'll work on a new configure option and make the changes Nicolas suggested.

My only concern is the following: Nicolas mentioned that the user-provided
value should take precedence. I think there are use cases for both.
Let's assume a person has a static build or a bundled ffmpeg version that
includes the necessary fontconfig files (relative to the binary). In that case
I want ffmpeg to use the bundled fontconfig files and not the ones that might
be installed on the system.
So if I set the --enable-portable[=path] config option, this path should take
precedence.

Cheers,
 Helmut


More information about the ffmpeg-devel mailing list