[FFmpeg-devel] [PATCH] Added an Adobe HTTP Dynamic Streaming (HDS) demuxer

CORY MCCARTHY cory.mccarthy at shaw.ca
Mon Feb 17 23:46:57 CET 2014

Complete patch with recent improvements

Fixed a crash that occurred when the manifest file contained more than 1024 fragment run table entries
Return EOF instead of looping back to the beginning for non live streams
Cannot assume the first fragment number will be zero

Ed, I was able to reproduce the crash with the information you sent.  Thank you.
I fixed it and sent an updated patch.

If you're able to test it with your setup, please let me know how it goes.


----- Original Message -----
From: "Ed Torbett" <ed.torbett at simulation-systems.co.uk>
To: "FFmpeg development discussions and patches" <ffmpeg-devel at ffmpeg.org>
Sent: Wednesday, January 29, 2014 5:49:00 AM
Subject: Re: [FFmpeg-devel] [PATCH] Added an Adobe HTTP Dynamic Streaming	(HDS) demuxer

> apply in other cases).  This can be fixed by changing the conditional part
> "fragment > segment_entry->fragments_per_segment" to "fragment >
> (fragment_entry->first_fragment + segment_entry->fragments_per_segment)".

Had a thought on this one. This will only work when fragment_entry is the only entry in the fragment table. Otherwise fragment_entry->first_fragment will be the wrong number sometimes.

In this case fragment_entry->first_fragment should probably be replaced with abst->fragment_run_table_boxes[0]-> fragment_run_entries[0]->first_fragment (i.e. the fragment number of the first fragment entry). I'm not sure if this takes the selected segment (if any) into account though.


ffmpeg-devel mailing list
ffmpeg-devel at ffmpeg.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hdsdec.patch
Type: text/x-patch
Size: 69524 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140217/12ee0e61/attachment.bin>

More information about the ffmpeg-devel mailing list