[FFmpeg-devel] [PATCH 3/5 v2] libx265: Support SAR

Michael Niedermayer michaelni at gmx.at
Fri Feb 21 20:36:00 CET 2014


On Fri, Feb 21, 2014 at 07:07:55PM +0000, Derek Buitenhuis wrote:
> Signed-off-by: Derek Buitenhuis <derek.buitenhuis at gmail.com>
> ---
>  libavcodec/libx265.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c
> index 47d9231..62dc53f 100644
> --- a/libavcodec/libx265.c
> +++ b/libavcodec/libx265.c
> @@ -77,6 +77,7 @@ static av_cold int libx265_encode_init(AVCodecContext *avctx)
>      libx265Context *ctx = avctx->priv_data;
>      x265_nal *nal;
>      uint8_t *buf;
> +    int sar_num, sar_den;
>      int nnal;
>      int ret;
>      int i;
> @@ -104,6 +105,15 @@ static av_cold int libx265_encode_init(AVCodecContext *avctx)
>      ctx->params->sourceWidth     = avctx->width;
>      ctx->params->sourceHeight    = avctx->height;
>  
> +    av_reduce(&sar_num, &sar_den,
> +              avctx->sample_aspect_ratio.num,
> +              avctx->sample_aspect_ratio.den, 4096);
> +    ctx->params->bEnableVuiParametersPresentFlag = 1;

> +    ctx->params->bEnableAspectRatioIdc           = 1;
> +    ctx->params->aspectRatioIdc                  = 255;
> +    ctx->params->sarWidth                        = sar_num;
> +    ctx->params->sarHeight                       = sar_den;

encoding a file with 0,0 aspect and one with 1,0 differ
and one with 5/7 aspect and 1/0 aspect differ only in 2 bytes
not setting bEnableAspectRatioIdc produces a smaller file

-rw-r----- 1 michael michael 13702 Feb 21 20:31 test0.hevc
-rw-r----- 1 michael michael 13701 Feb 21 20:33 test10.hevc
-rw-r----- 1 michael michael 13701 Feb 21 20:31 test57.hevc
-rw-r----- 1 michael michael 13696 Feb 21 20:31 test-.hevc

so i suspect there are no checks in x265 or the checks dont work

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140221/099a61d1/attachment.asc>


More information about the ffmpeg-devel mailing list