[FFmpeg-devel] [PATCH] lavf: add subfile protocol.

Nicolas George george at nsup.org
Wed Feb 26 11:56:30 CET 2014


Le septidi 7 ventôse, an CCXXII, Lukasz Marek a écrit :
> Probably handled in other place, but you can check if flag doesn't
> require writing.

This is indeed handled by the framework.

> If I remember correctly 0 should be returned. condition can be rest <= 0

Both should work, but I changed it to 0 for consistency's sake.

> seems like seeking below start offset will corrupt it.
> For example SEEK_SET with pos equals to -c->start

You are right, that case was not properly handled.

Updated patch attached, thanks for the review.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavf-add-subfile-protocol.patch
Type: text/x-diff
Size: 7504 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140226/ff030f10/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140226/ff030f10/attachment.asc>


More information about the ffmpeg-devel mailing list