[FFmpeg-devel] [PATCH 4/8] lavu/opt: extend AVOptionRange by second value
george at nsup.org
Wed Feb 26 12:41:47 CET 2014
L'octidi 8 ventôse, an CCXXII, Lukasz M a écrit :
> Hmm, I treated it a bit different, but I think your proposition is correct.
> So for example for size opt value would be number of pixels. components
> would define ranges of width and height?
Maybe I missed something, but I suspect you should completely ignore the
> I share your opinion. But technically this is api break. At major bump
> extra_value_min can be removed and value_min/max can be array as in my
> first patch.
> On the other hand I believe in practice it would be better to change it
> now. I doubt query_ranges is commonly used so far outside ffmpeg. When dev
> cap api starts relying on it, users may start to use it more.
Is there really a benefit in having a real array, i.e. being able to handle
both values at once? If not, you could just add value2_min/max and be done
with it. That has the advantage of not polluting the normal code with "".
Also, is it worth the complexity? IIRC, you did not respond to the option of
leaving width and height separate, and just set width to get the
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 819 bytes
Desc: Digital signature
More information about the ffmpeg-devel