[FFmpeg-devel] [PATCH 2/5] libavcodec: Implementation of AC3 fixed point decoder

[Timothy Gu]

On Tue, Jan 21, 2014 at 8:05 AM, Nedeljko Babic
<Nedeljko.Babic at imgtec.com> wrote:
>>>
>>> From: Nedeljko Babic <nbabic at mips.com>
>>>
>>> Signed-off-by: Nedeljko Babic <nbabic at mips.com>
>>> ---
>>>  libavcodec/Makefile       |   3 +-
>>>  libavcodec/ac3.h          |  44 +++++++++++
>>>  libavcodec/ac3dec.c       | 196
>>+++++++++++++++++++++++++---------------------
>>>  libavcodec/ac3dec.h       |  33 ++++----
>>>  libavcodec/ac3dec_fixed.c | 176 +++++++++++++++++++++++++++++++++++++++++
>>>  libavcodec/ac3dec_float.c |  89 +++++++++++++++++++++
>>>  libavcodec/ac3dsp.c       |  26 ++++++
>>>  libavcodec/ac3dsp.h       |   3 +
>>>  libavcodec/allcodecs.c    |   1 +
>>>  libavcodec/kbdwin.c       |  10 +++
>>>  libavcodec/kbdwin.h       |   1 +
>>>  libavcodec/version.h      |   2 +-
>>>  12 files changed, 477 insertions(+), 107 deletions(-)
>>>  create mode 100644 libavcodec/ac3dec_fixed.c
>>>  create mode 100644 libavcodec/ac3dec_float.c
>>
>>Missing doc/general update
>
> I will wait for a few days to see if there will be additional comments on the patch and then add doc/general update and resend patchset.
>
> I have a question regarding this.
> I saw that for AC-3 encoder IX is used.

> I guess that "I" stands for integer (I didn't find documentation regarding this).

Yes. See line 960.

> Is it enough to add the same for decoder (since it is just X now), or I need to add entirely new entry for fixed point AC3.

Just changing decoder to IX is enough.

Timothy