[FFmpeg-devel] [PATCH] Properly handle cookies that specify sub-domain where the URL.
michaelni at gmx.at
Thu Jan 23 14:49:07 CET 2014
On Thu, Jan 23, 2014 at 08:34:20AM +0000, Eli Kara wrote:
> > > While I don't remember the C boolean type, I just wanted to note that the variable is only used once and therefore probably unneeded.
> > > Please remove the tabs and consider to shorten the comment lines.
> > You don't remember it because it doesn't exist (smiles). I did check
> > the C standard and it clearly states that relational operators return 1 or 0 with type int, so my comment is relevant to C++ only, sorry about that.
> > I still think it is clearer with the leading_dot variable. You could place the statement inside the call to av_strdup but that would look unintelligible IMO.
> > The other alternative would be another if or conditional statement.
> > I'll wait a while longer to see if anyone else has any comments on this..
> > IMHO feel free to leave the variable in there
> Done. Here is the revised patch, please take a look whenever is convenient.
> I have a few small question though -
> What happens when a patch gets applied ? Is it mirrored on Github or just on the original git repository in ffmpeg's site?
> Also, if patch fixes a known bug in the tracker, who's responsibility is it to close it ?
> libavformat/http.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel