[FFmpeg-devel] [PATCH] ffmpeg: use intermediary variables in reap_filters, increase readability

Stefano Sabatini stefasab at gmail.com
Sun Jan 26 18:14:19 CET 2014


On date Saturday 2014-01-25 17:41:46 +0100, Nicolas George encoded:
> Le quintidi 5 pluviôse, an CCXXII, Stefano Sabatini a écrit :
> > ---
> >  ffmpeg.c | 23 +++++++++++------------
> >  1 file changed, 11 insertions(+), 12 deletions(-)
> > 
> > diff --git a/ffmpeg.c b/ffmpeg.c
> > index 0685ff5..b9ed875 100644
> > --- a/ffmpeg.c
> > +++ b/ffmpeg.c
> > @@ -1091,6 +1091,8 @@ static int reap_filters(void)
> >      for (i = 0; i < nb_output_streams; i++) {
> >          OutputStream *ost = output_streams[i];
> >          OutputFile    *of = output_files[ost->file_index];
> 
> > +        AVFilterContext *filt_ctx = ost->filter->filter;
> > +        AVCodecContext *enc_ctx = ost->st->codec;
> 
> I find the names rather ugly. "filter" and "enc" or "encoder" would please
> my eyes more.
> 
> But I agree that both version increase readability.

Will change and push it soon.
-- 
FFmpeg = Faithful & Fancy Muttering Patchable Elitarian Gem


More information about the ffmpeg-devel mailing list