[FFmpeg-devel] [PATCH 3/3] web/download: Rename builds anchors so old links posted elsewhere still work

Lou Logan lou at lrcd.com
Tue Jul 22 20:34:13 CEST 2014


On Mon, 21 Jul 2014 20:37:36 +0200, db0company wrote:

> ---
>  htdocs/js/download.js |   10 +++++-----
>  src/download          |   13 +++++++------
>  src/less/style.less   |   12 ++++++------
>  3 files changed, 18 insertions(+), 17 deletions(-)
> 
> diff --git a/htdocs/js/download.js b/htdocs/js/download.js
> index b4807b5..7ac9c91 100644
> --- a/htdocs/js/download.js
> +++ b/htdocs/js/download.js
> @@ -1,15 +1,15 @@
>  
>  $(document).ready(function() {
> -	$('#build-windows').removeClass('active');
> -	$('#build-mac').removeClass('active');
> +	$('#WindowsBuilds').removeClass('active');
> +	$('#MacOSXBuilds').removeClass('active');
>  
>  	var f = function (e) {
>  	    e.preventDefault()
>  	    $(this).tab('show')
>  	};
> -	$('a[href="#build-linux"]').hover(f);
> -	$('a[href="#build-windows"]').hover(f);
> -	$('a[href="#build-mac"]').hover(f);
> +	$('a[href="#LinuxBuilds"]').hover(f);
> +	$('a[href="#WindowsBuilds"]').hover(f);
> +	$('a[href="#MacOSXBuilds"]').hover(f);
>  
>  	$("#get-sources").height($("#get-packages").height());
>  	$("#get-packages").height($("#get-packages").height());
> diff --git a/src/download b/src/download
> index fb30ed0..ad54ad3 100644
> --- a/src/download
> +++ b/src/download
> @@ -31,17 +31,17 @@
>          <div class="os-selector">
>            <div class="row">
>              <div class="col-xs-4">
> -              <a class="btn-build active" href="#build-linux">
> +              <a class="btn-build active" href="#LinuxBuilds">
>                  <i class="fa fa-5x fa-fw fa-linux"></i>
>                </a>
>              </div> <!-- col -->
>              <div class="col-xs-4">
> -              <a class="btn-build" href="#build-windows">
> +              <a class="btn-build" href="#WindowsBuilds">
>                  <i class="fa fa-5x fa-fw fa-windows"></i>
>                </a>
>              </div> <!-- col -->
>              <div class="col-xs-4">
> -              <a class="btn-build" href="#build-mac">
> +              <a class="btn-build" href="#MacOSXBuilds">
>                  <i class="fa fa-5x fa-fw fa-apple"></i>
>                </a>
>              </div> <!-- col -->
> @@ -49,7 +49,7 @@
>          </div> <!-- os-selector -->
>  
>          <div class="tab-content">
> -          <div id="build-linux" class="tab-pane active">
> +          <div id="LinuxBuilds" class="tab-pane active">
>  
>              <h3>Linux Packages</h3>
>              <div class="list-group">
> @@ -77,7 +77,7 @@
>              </div> <!-- list-group -->
>  
>            </div> <!-- build -->
> -          <div id="build-windows" class="tab-pane active">
> +          <div id="WindowsBuilds" class="tab-pane active">
>  
>              <h3>Windows Packages</h3>
>  
> @@ -88,7 +88,7 @@
>              </div> <!-- list-group -->
>  
>            </div> <!-- build -->
> -          <div id="build-mac" class="tab-pane active">
> +          <div id="MacOSXBuilds" class="tab-pane active">
>  
>              <h3>Mac OS X Packages</h3>

The "Mac" should be removed from this title since Apple dropped that
from the OS X naming schemes. I know it's in the anchors, but we can
keep it in those for link preservation.

No other comments from me.


More information about the ffmpeg-devel mailing list