[FFmpeg-devel] [PATCH] Fix nonsense non-mod16 AMV flipping code.
Reimar.Doeffinger at gmx.de
Mon Jun 2 21:13:41 CEST 2014
On Sun, Jun 01, 2014 at 07:50:55AM +0000, Carl Eugen Hoyos wrote:
> Carl Eugen Hoyos <cehoyos <at> ag.or.at> writes:
> > Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:
> > > It is obviously nonsense since it produces wrong results
> > > or even crashes (crashes should be encode-only though).
> > > Fixes trac issue #1092.
> > Ping, the ticket is still reproducible.
> It is not reproducible anymore, but the ping still applies.
I have to admit I didn't push this patch further because when
I recently stumbled over it I could hardly understand it and
had no idea if it is correct :-(
I certainly won't object to it being applied, but if someone
feels like double-checking the code surrounding AMV and non-mod-16
sizes and if it even makes sense (disregarding now whether it
matches behaviour of some reference decoder) that is welcome.
More information about the ffmpeg-devel