[FFmpeg-devel] [PATCH]flvenc Allow ffmpeg -copy on rtmp outputs from udp inputs

[Michael Niedermayer]

On Sat, Jun 07, 2014 at 09:54:05PM +0200, Tudor SUCIU wrote:
> Hello,
> 
> I had more time to look at my .ts to rtmp case with -acodec copy and
> -vcodec copy.
> For the audio this patch seems enough to fix the problems.
> For the video i'm looking into it, it seems that ffmpeg does not filter
> SPS, PPS and AUD h264 NALs when sending to h264 in flv encapsulation. Mp4
> is also affected.
> I'll try to concentrate this patch on the audio part and will try to see in
> the future if I can produce a patch that fixes the h264 issues for my input
> file.
> 
> I hope there are no more code issues, as i was not sure if the patch will
> be taken into account i didn't clean it properly. Sorry for wasting your
> time.

you said similar code is in the mp4 muxer and i see similar code in
matroskadec line 1820

I think factorizing all these instances from libavformat into a
single case if possible should happen.
I suggest this also because the code in matroskadec considers
profile and SBR, which your code ignores

also muxers should not write to the extradata field of AVCodecContext
a local variable seems more correct

and then please see libavcodec/aac_adtstoasc_bsf.c and check if
using it would fix the issue you are trying to fixe

and please provide a sample and commandline (testcase)

[...]

Thanks
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140607/9378478d/attachment.asc>