[FFmpeg-devel] [PATCH] avcodec/ppc/idct_altivec: add plain idct()
michaelni at gmx.at
Sat Jun 14 20:43:26 CEST 2014
On Sat, Jun 14, 2014 at 08:22:15PM +0200, Christophe Gisquet wrote:
> 2014-06-14 20:06 GMT+02:00 Michael Niedermayer <michaelni at gmx.at>:
> > i dont really know altivec / the advantages of direct assignment vs
> > using vec_st*() and i dont have hw to test either
> > so if my patch is silly in some way, please submit a correct one
> > and ill apply it
> I was cargo-culting as I don't know altivec, and actually, block is
> already vec_s16, so I had the offsets wrong. I only commented in case
> compilation failed.
> Your solution works, so unless Carl wants to take the time to verify
> if the 2 syntaxes generate different instructions with objdump, yours
> is fine and should be applied.
> And if it happens not to be, the vec_st stuff will have to be checked.
it is working IIUC, so
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
It is what and why we do it that matters, not just one of them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 181 bytes
Desc: Digital signature
More information about the ffmpeg-devel