[FFmpeg-devel] [PATCH 4/8] lavu/opt: extend AVOptionRange by second value

[Lukasz Marek]

On 02.03.2014 15:54, Nicolas George wrote:
> Le decadi 10 ventôse, an CCXXII, Lukasz Marek a écrit :
>> I promise it is the last one. No more from me for this thread unless
>> you decide what you want :P
>
> I would suggest to drop this part for now and concentrate on landing the
> device probe API itself. The device probing does not actually need the
> extended range structure, these enhancements can be added later.

But it is required to decide how window/frame size is probed. By size 
opt or width/height separately. I prefer by size, but it require 
extension of the struct and I haven't been expecting it may be so 
overcomplicated.

> So my advice is to finish the probing API, and see how it works to see how
> the range structure can be improved.
>
>> +    double multiple_of;                        ///< Valid values have to be multiple of multiple_of. Ignore if multiple_of is 0.
>
> Same thing here: you do not have to feel obligated to implement every
> suggestion that appears in the discussion. Even when they are a good idea,
> if they are not necessary for the work you can leave them for a separate
> patch series.

Indeed, this can be added as separate patch later.

-- 
Best Regards,
Lukasz Marek

You can avoid reality, but you cannot avoid the consequences of avoiding 
reality. - Ayn Rand