[FFmpeg-devel] [PATCH] Set padding_bug_score to zero at the start of each frame

gregory.wolfe at kodakalaris.com gregory.wolfe at kodakalaris.com
Mon Mar 3 22:36:37 CET 2014


Greetings!  At Kodak Alaris (we're the Kodak photo kiosk people) we are
using FFmpeg to extract frames from customer video files so that they can
be included in print products (e.g., photo books, collages, calendars).

I have just completed updating the version of FFmpeg we are using from
ffmpeg-0.5 (circa 2009) to the latest development branch.  This is the 
first
of two changes I've made.  I have read and attempted to follow all the
recommendations for submitting patches, but please advise if I missed
something.

The full patch is in two patch files (sorry) because I'm somewhat new at
using git (we use ClearCase).  I've also attached before/after command
line output from ffmpeg.  A test video file that can be used to generate
the before/after output, H263PaddingBugFixVID_6647.MOV, has been
uploaded to the FFmpeg FTP server.

FYI, I am using the MinGW32 build environment on Windows 7.


Patched file:  libavcodec/h263dec.c
Description (from commit message):

Set padding_bug_score to zero at the start of each frame.

If the padding_bug_score is not zeroed out at the start of each frame,
negative increments can accumulate.  This can result in the padding bug
fix-up code not running, and you get an error condition from
decode_slice() with the message "slice end not reached but screenspace
end ...".


Greg Wolfe, Kodak Alaris





-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Set-padding_bug_score-to-zero-at-the-start-of-each-f.patch
Type: application/octet-stream
Size: 1300 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140303/67e9c93b/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Set-padding_bug_score-to-zero-at-the-start-of-each-f.patch
Type: application/octet-stream
Size: 1415 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140303/67e9c93b/attachment-0001.obj>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: H263PaddingBugFixBefore.txt
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140303/67e9c93b/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: H263PaddingBugFixAfter.txt
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140303/67e9c93b/attachment-0001.txt>


More information about the ffmpeg-devel mailing list