[FFmpeg-devel] [PATCH 1/4] lavu: add simple array implementation

Michael Niedermayer michaelni at gmx.at
Wed Mar 5 01:43:50 CET 2014

On Wed, Mar 05, 2014 at 12:38:55AM +0100, Lukasz Marek wrote:
> On 05.03.2014 00:26, Don Moir wrote:
> >>From: "Michael Niedermayer" <michaelni at gmx.at>
> >>To: "FFmpeg development discussions and patches"
> >><ffmpeg-devel at ffmpeg.org>
> >have 2) and the way Lukasz is trying to design it is the right way to
> >go. I have been using a similiar method for many years and use it for a
> >variety of things and always accomodates. Works from C but with C++ I
> >also use templates which makes it even better with less explicit
> >initialization and free and it's typed.
> >
> >I would rename Lukasz deleter to destructor though. Also within the
> >struct, I provide a lock if you choose to use it. I use dynamic arrays a
> >lot and sometimes with multi-thread usage. The way Lukasz is trying to
> >design it probably has too much in it, but he is trying to accomodate
> >the older implementations I believe. The other implementations should be
> >marked as deprecated and re-routed to a new implementation in my opinion.
> Thanks, at least one person likes mine solution. TBH I don't
> understand what is the problem with it. It can do to much? Or it is
> too easy to use?

Developers know C and other standard things, everything beyond that
needs to be learnt. A complex API that basically wraps over C arrays
puts burden on the people who have to understand and work with the
Thats why i suggest to add what we need but be carefull about adding
things that drive its complexity up but that we dont need

Also this API is inefficient which would make it unuseable in speed
relevant code, requireing something else, or some macros / inline
functions which would cast part of the internal design in stone


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140305/d39ebc13/attachment.asc>

More information about the ffmpeg-devel mailing list