[FFmpeg-devel] [PATCH]Move ff_log2_run definition into put_bits.h
michaelni at gmx.at
Sun Mar 9 20:34:03 CET 2014
On Sun, Mar 09, 2014 at 07:59:34PM +0100, Carl Eugen Hoyos wrote:
> Attached patch fixes a compilation warning that ff_log2_run is defined with a
> different size in jpegls.h.
> Please comment, Carl Eugen
> ffv1.h | 2 --
> jpegls.h | 3 +--
> put_bits.h | 2 ++
> diff --git a/libavcodec/put_bits.h b/libavcodec/put_bits.h
> index 8081fb9..e780285 100644
> --- a/libavcodec/put_bits.h
> +++ b/libavcodec/put_bits.h
> @@ -237,4 +237,6 @@ static inline void set_put_bits_buffer_size(PutBitContext *s, int size)
> s->buf_end = s->buf + size;
> +extern const uint8_t ff_log2_run;
this could be in internal.h or something else
put_bits is wrong as its not encoder specific
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel