[FFmpeg-devel] [PATCH] doc/examples/muxing: make compatible with C++
nfxjfg at googlemail.com
Fri Mar 14 16:35:45 CET 2014
On Fri, 14 Mar 2014 18:01:07 +0800
"Geek.Song" <ffmpeg at gmail.com> wrote:
> +1, Why do we pollute the code with C++?
I don't see any pollution in the original patch. There were just two
1. extern "C" - this should be directly in the ffmpeg headers anyway.
2. Passing or-ed flags to an enum parameter. The parameter should be
int in the first place, because enums usually take only values that
are part of the enumeration. It's confusing that it allows/requires
combinations of flags instead.
Both could have been avoided with cleaner and more standard practices.
More information about the ffmpeg-devel