[FFmpeg-devel] *** GMX Spamverdacht *** Re: [PATCH] doc/examples/muxing: make compatible with C++

Michael Niedermayer michaelni at gmx.at
Sun Mar 16 21:18:36 CET 2014

On Sun, Mar 16, 2014 at 08:58:03PM +0100, Michael Niedermayer wrote:
> On Sun, Mar 16, 2014 at 08:00:50PM +0100, Nicolas George wrote:
> > Le quartidi 24 ventôse, an CCXXII, Michael Niedermayer a écrit :
> > > We could add a comment that clarifies that the casts are bad practice
> > > in C but needed to support C++
> > 
> > What about the other way around: add comments about the required changed to
> > make it compatible with c++, but keep the actual code pure C?
> adding comments doesnt turn "not compiling code" into "compiling code"
> We or well at least I dont want to inconvenience our users
> Examples that can be build out of the box as C and C++ are a lot
> more convenient than examples that differ in 6 lines of code and
> build just with a C compiler and then somewhere there are comments
> explaining the modifications neccessary to make them build with C++.
> (which arent easily regression testable btw ...)
> A C++ developer who tries to use the code in a C++ application maybe
> wont even find these comments.
> Thats a big disadvantage for her. Can you elaborate on what the
> advantage of having it "not work with C++" is ?
> Iam a bit surprised by the negative reaction toward this patch
> we accepted far worse to make ffmpeg work on obscure platforms.
> Also for example see "Patch: Inline asm fixes for Intel compiler on Windows"
> do you consider that patchset clean and a good idea while this here
> is ugly and bad and problematic?

also if people hate it so much, maybe we could include the patch
and create a muxing.cpp via makefile from it and muxing.c ?
would that resolve peoples concerns ?


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140316/287d9cda/attachment.asc>

More information about the ffmpeg-devel mailing list