[FFmpeg-devel] Patch: Inline asm fixes for Intel compiler on Windows

Michael Niedermayer michaelni at gmx.at
Sat Mar 22 16:16:56 CET 2014


On Sat, Mar 22, 2014 at 04:24:27PM +1100, Matt Oliver wrote:
> >
> >
> >> applied most of it
> >
> >
> > Ill see if I can find another way to get icl to compile while still using
> > MANGLE but if memory serves I tried basically every combination I could
> > think off and couldnt get it to compile any other way. Are there any issues
> > with fixing it the way I did?
> >
> 
> OK so I couldnt get icl to play nice with that 1 MANGLE line. The only way
> ive been able to get it to work is to add round_tab[2] to the asm interface
> instead of having it as a direct symbol reference. This should not be a
> problem as this is how all the other sad_xxx functions use round_tab (see
> x86/motion_est.c lines 351, 366, 408, 423 ). The patch is attached.
> 
> Also now that the named reference patch has been applied to ffmpeg then the
> corresponding changes to libmpcodec can now be applied (patch 4/4 also
> attached). libmpcodes is the only part that hasnt been updated yet with the
> new changes (this may also be useful for the lto problem Carl was working
> on).
> Reimar Döffinger apparently applied the last set of patches (patches 1/4 ->
> 3/4) to upstream mplayer so if he or someone else can get this applied
> upstream (assuming everything looks good of course).
> Once that is done then the upstream libmpcodec can be merged into ffmpeg as
> the first 3 fixes applied upstream over a month ago still havnt been synced.

>  motion_est.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> eee662e5bd3c1afcbf175174527587342f999cd0  Additional-icl-inline-asm-fix.patch
> From 3aed84433ff4dd10ce3194b69905377559527149 Mon Sep 17 00:00:00 2001
> From: Matt Oliver <protogonoi at gmail.com>
> Date: Sat, 22 Mar 2014 15:59:12 +1100
> Subject: [PATCH] Additional icl inline asm fix.

applied

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140322/53103da3/attachment.asc>


More information about the ffmpeg-devel mailing list