[FFmpeg-devel] [PATCH] Add a gamma flag to exr loader to avoid banding

Michael Niedermayer michaelni at gmx.at
Thu May 8 15:43:23 CEST 2014


On Thu, May 08, 2014 at 10:20:22AM -0300, Gonzalo Garramuno wrote:
> On 07/05/14 23:30, Michael Niedermayer wrote:
> >this one fails again:
> The only things I changed were the defines and used av_intfloat32 to
> avoid the aliasing problem.  There's something more severely broken
> in the test suite.  I attach a version with returning av_intfloat32
> instead of a float and see if that passes.
> 

fails:
also can you get rid of all floats int->union->float on the main
gamma=1 path ?
IIRC they are only used to transport a unchanged value,

--- ./tests/ref/fate/exr-slice-raw      2014-05-08 15:37:58.078114782 +0200
+++ tests/data/fate/exr-slice-raw       2014-05-08 15:39:33.578116794 +0200
@@ -1,2 +1,2 @@
 #tb 0: 1/25
-0,          0,          0,        1,  3169800, 0x1f656d7a
+0,          0,          0,        1,  3169800, 0xdc8f6d0b
TEST    sunraster-24bit-rle
Test exr-slice-raw failed. Look at tests/data/fate/exr-slice-raw.err for details.
make: *** [fate-exr-slice-raw] Error 1
make: *** Waiting for unfinished jobs....
--- ./tests/ref/fate/exr-slice-rle      2014-05-08 15:37:58.078114782 +0200
+++ tests/data/fate/exr-slice-rle       2014-05-08 15:39:33.598116794 +0200
@@ -1,2 +1,2 @@
 #tb 0: 1/25
-0,          0,          0,        1,  3169800, 0x1f656d7a
+0,          0,          0,        1,  3169800, 0xdc8f6d0b
Test exr-slice-rle failed. Look at tests/data/fate/exr-slice-rle.err for details.
make: *** [fate-exr-slice-rle] Error 1
--- ./tests/ref/fate/exr-slice-zip16    2014-05-08 15:37:58.082114782 +0200
+++ tests/data/fate/exr-slice-zip16     2014-05-08 15:39:33.622116794 +0200
@@ -1,2 +1,2 @@
 #tb 0: 1/25
-0,          0,          0,        1,  3169800, 0x1f656d7a
+0,          0,          0,        1,  3169800, 0xdc8f6d0b
Test exr-slice-zip16 failed. Look at tests/data/fate/exr-slice-zip16.err for details.
make: *** [fate-exr-slice-zip16] Error 1
--- ./tests/ref/fate/exr-slice-zip1     2014-05-08 15:37:58.082114782 +0200
+++ tests/data/fate/exr-slice-zip1      2014-05-08 15:39:33.630116795 +0200
@@ -1,2 +1,2 @@
 #tb 0: 1/25
-0,          0,          0,        1,  3169800, 0x1f656d7a
+0,          0,          0,        1,  3169800, 0xdc8f6d0b
Test exr-slice-zip1 failed. Look at tests/data/fate/exr-slice-zip1.err for details.
make: *** [fate-exr-slice-zip1] Error 1

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

DNS cache poisoning attacks, popular search engine, Google internet authority
dont be evil, please
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140508/334af3d7/attachment.asc>


More information about the ffmpeg-devel mailing list