[FFmpeg-devel] [PATCH 1/6] lavu: add av_gettime_relative()

[Olivier Langlois]

On Sat, 2014-05-10 at 19:29 +0200, Nicolas George wrote:
> L'octidi 18 floréal, an CCXXII, LANGLOIS Olivier PIS -EXT a écrit :
> > Yes. that was on purpose. While it is true that the function
> > av_gettime_monotonic() from lavd does not conflict anymore since we
> > renamed the function in lavu, they are still essentially identical so in
> > order to avoid unnecessary code replication, I have made v4l2 use the new
> > lavu function as in previous versions of the patch. One could argue that
> > since the function av_gettime_relative() may not always be implemented as
> > monotonic, in order to avoid a possible maintenance glitch in case that
> > theoretically av_gettime_relative() on Linux would stop being identical to
> > v4l2's av_gettime_monotonic(), it would be better to leave v4l2.c as is.
> > 
> > If that is what you have in mind, I can drop these changes. Just let me
> > know if I read your comment correctly.
> 
> I think you missed my meaning. The change to v4l2 is good in itself, I was
> asking why you kept it together with the change to lavu, while you split the
> other changes into separate patches.
> 
I finally understand.

I sent a new version including rework based on your comments. I have
splitted lavu and lavd changes into 2 distinct patches and I have
modified the v4l2 changes. IMHO, the new version and the previous one
are equivalent. It is just a matter of taste so I'll be waiting to know
which form you prefer.

Greetings,
Olivier