[FFmpeg-devel] [PATCH] x86/dsputil: port clear_block functions to yasm

[Christophe Gisquet]

Hi,

2014-05-21 8:53 GMT+02:00 James Almer <jamrial at gmail.com>:
> +INIT_XMM sse
> +%define ZERO xorps
> +CLEAR_BLOCK 1, 1
[...]
> +INIT_XMM sse
> +%define ZERO xorps
> +CLEAR_BLOCKS 1

Maybe it crossed your mind and then you crossed it out for lack of
benefit, but a sse2 and even maybe an avx version might make sense?

> +#if HAVE_YASM
> +#if HAVE_SSE_EXTERNAL

>From the discussion on HAVE_MMX_EXTERNAL, I would expect
HAVE_SSE_EXTERNAL implies HAVE_YASM.
Probably needs a confirmation from someone knowing what he's talking
about (i.e. not me).

Otherwise OK, this is a straightforward conversion.

Best regards,
-- 
Christophe