[FFmpeg-devel] [PATCH] dvbsub fix transcoding
Wim Vander Schelden
lists at fixnum.org
Thu May 22 15:01:43 CEST 2014
These subtitles not disappearing is exactly the issue that's introduced by
sending the second (empty, "clearing") packet (by removing the nb = 2).
Note that you are now relying on the DVB subtitle timeout value, which is
only for "safety" purposes (ie, the encoder crashed), and is only required
by the specification to be followed with a 5 second accuracy (so it is
completely useless for functioning subtitles)!
On Thu, May 22, 2014 at 2:55 PM, anshul <anshul.ffmpeg at gmail.com> wrote:
> On 05/22/2014 05:42 PM, Carl Eugen Hoyos wrote:
>> anshul <anshul.ffmpeg <at> gmail.com> writes:
>> I tested your patch with the first sample from
>>>> ticket #2024 (Starship_Troopers.vob) and as far
>>>> as I can tell, it breaks the output. Does it work
>>>> for you?
>>> Yes,its work for me for 1st Video also
>> Please run:
>> $ ffplay Starship_Troopers.vob
>> $ ffplay test.ts
>> and compare carefully.
>> Carl Eugen
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
> While comparing carefully, only issue that i find is that
> subtitles(output) does not dissapear while they disappear in input.
> I have attached new patch considering the issue that i noticed.
> I really don't know what issue you noticed.
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
More information about the ffmpeg-devel