[FFmpeg-devel] [RFC] [PATCH] tests: add a third, 162x144, target

[Michael Niedermayer]

On Fri, May 30, 2014 at 03:22:28PM +0200, Christophe Gisquet wrote:
> Hi,
> 
> recent work on huffyuvdsp showed some corner cases (namely dimensions
> that are not multiple of 8, e.g. 162) did not work. I think this
> underlined one of the problems with fate, that the fate-vsynth* tests
> generate 352x288 files only and can't evaluate that kind of test.
> 
> Some more work is needed to determine which tests can actually work
> with this (I'm thinking of some formats/profiles/... having hardcoded
> dimensions for isntance).
> 
> In addition, we may even test 18x6 sequences to also evaluate
> excessive unrolling. If we want to keep the unrolling in specific
> encoders/decoders, then maybe said encoders/decoders should reject
> such atypical dimensions.
> 
> Furthermore, as is, this patch does not work as there aren't reference
> results yet. As I don't know how and what to add, it should be seen
> more as a RFC.
> 
> Best regards,
> -- 
> Christophe

>  Makefile        |    3 +++
>  fate/vcodec.mak |    9 +++++++--
>  2 files changed, 10 insertions(+), 2 deletions(-)
> b6c13d0469e91dc776543c92cde97c725219a0b0  0004-tests-add-a-third-162x144-target.patch
> From 74113202a4bd382c89703808da9f5fcdcb72f081 Mon Sep 17 00:00:00 2001
> From: Christophe Gisquet <christophe.gisquet at gmail.com>
> Date: Fri, 30 May 2014 11:58:57 +0200
> Subject: [PATCH 4/4] tests: add a third, 162x144, target
> 
> This should exercise the corner cases of numerous codecs.
> ---
>  tests/Makefile        |    3 +++
>  tests/fate/vcodec.mak |    9 +++++++--
>  2 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/Makefile b/tests/Makefile
> index 2a99199..9645158 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -30,6 +30,9 @@ tests/data/vsynth1.yuv: tests/videogen$(HOSTEXESUF) | tests/data
>  tests/data/vsynth2.yuv: tests/rotozoom$(HOSTEXESUF) | tests/data
>  	$(M)$< $(SRC_PATH)/tests/lena.pnm $@
>  
> +tests/data/vsynth3.yuv: tests/videogen$(HOSTEXESUF) | tests/data
> +	$(M)$< $@ 162 144

144 is a multiple of 4, it might test more corner cases if its not

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140530/1f6b5a1d/attachment.asc>