[FFmpeg-devel] [PATCH] vdpau_mpeg4: Do not fail on unknown profile.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat Nov 1 15:10:53 CET 2014


On Sat, Nov 01, 2014 at 02:18:06PM +0100, Jean-Baptiste Kempf wrote:
> On 01 Nov, Reimar Döffinger wrote :
> > This is a regression, previous code did not require
> > users to set the profile to use VDPAU.
> 
> If you don't set the profile, how can you know that the hardware
> supports it?

Firstly: As I said, SP is a subset of ASP, so if the hardware supports ASP
it supports SP.
Secondly: The code actually interacting with the hardware can handle
that. There is no need for the FFmpeg decoder to require that
information.
Obviously I can just hack around this by setting it to ASP if it's
unknown, but I'd like a good reason why that is a better solution than
graceful degradation here.

Only slightly related:
I generally dislike that part of the design as it mixes up the whole VDPAU
structure/bitstream generation with the actual hardware decoding,
which is a pain if you want to use security feature like process
separation of decoding (which is a higher security risk) from
actual display.


More information about the ffmpeg-devel mailing list