[FFmpeg-devel] [PATCH] swscale: Enable yuv2planeX_8 assembly that had been disabled for some reason

James Almer jamrial at gmail.com
Sun Nov 9 04:06:42 CET 2014


On 08/11/14 11:37 PM, Kieran Kunhya wrote:
> From 196dd0d9eb40ca18e3bba993f5198bd1bde536ce Mon Sep 17 00:00:00 2001
> From: Kieran Kunhya <kierank at ob-encoder.com>
> Date: Sat, 8 Nov 2014 20:34:25 -0600
> Subject: [PATCH] swscale: Enable yuv2planeX_8 assembly that had been disabled
>  for some reason
> 
> ---
>  libswscale/x86/swscale.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c
> index 8ce87b3..8a688b3 100644
> --- a/libswscale/x86/swscale.c
> +++ b/libswscale/x86/swscale.c
> @@ -430,7 +430,7 @@ switch(c->dstBpc){ \
>      case 16:                          do_16_case;
>      break; \
>      case 10: if (!isBE(c->dstFormat)) vscalefn = ff_yuv2planeX_10_ ##
> opt; break; \
>      case 9:  if (!isBE(c->dstFormat)) vscalefn = ff_yuv2planeX_9_  ##
> opt; break; \
> -    default: if (condition_8bit)    /*vscalefn = ff_yuv2planeX_8_  ##
> opt;*/ break; \
> +    default: if (condition_8bit)      vscalefn = ff_yuv2planeX_8_  ##
> opt; break; \
>      }
>  #define ASSIGN_VSCALE_FUNC(vscalefn, opt1, opt2, opt2chk) \
>      switch(c->dstBpc){ \
> --
> 1.7.9.5
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This breaks ten filter-pixfmts FATE tests when using SSE2 or above (at least on 
x86_64), so i guess that's why it was disabled.

Enabling the mmxext version until the rest are fixed is probably a better idea 
than disabling everything, though.


More information about the ffmpeg-devel mailing list