[FFmpeg-devel] [PATCH] avfilter/avf_showwaves: fix off by one error in loop condition

Michael Niedermayer michaelni at gmx.at
Sun Nov 9 16:43:58 CET 2014


On Sun, Nov 09, 2014 at 01:37:03PM +0000, Paul B Mahol wrote:
> On 11/9/14, Marton Balint <cus at passwd.hu> wrote:
> > It caused segfaults.
> >
> > Signed-off-by: Marton Balint <cus at passwd.hu>
> > ---
> >  libavfilter/avf_showwaves.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavfilter/avf_showwaves.c b/libavfilter/avf_showwaves.c
> > index 4cd225a..fa34a52 100644
> > --- a/libavfilter/avf_showwaves.c
> > +++ b/libavfilter/avf_showwaves.c
> > @@ -157,7 +157,7 @@ inline static int push_frame(AVFilterLink *outlink)
> >          showwaves->req_fullfilled = 1;
> >      showwaves->outpicref = NULL;
> >      showwaves->buf_idx = 0;
> > -    for (i = 0; i <= nb_channels; i++)
> > +    for (i = 0; i < nb_channels; i++)
> >          showwaves->buf_idy[i] = 0;
> >      return ret;
> >  }
> > --
> > 2.1.2
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> ok

applied

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141109/36694e5d/attachment.asc>


More information about the ffmpeg-devel mailing list