[FFmpeg-devel] [PATCH 1/9] lavu/opt: introduce av_opt_is_set_to_default()

Nicolas George george at nsup.org
Wed Nov 12 09:03:10 CET 2014


Le primidi 21 brumaire, an CCXXIII, Lukasz Marek a écrit :
> TODO: bump minor version, update doc/APIchanges
> 
> New function allows to check if option is set to its default

I am a bit uncomfortable with that API: this function does not test whether
an option is set to its default but if an option is set to the same value as
its default. That leaves a lot of room for bad use. If the user explicitly
sets an option to a value, it should not be considered default, even if the
value is the same as the default.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141112/629767e7/attachment.asc>


More information about the ffmpeg-devel mailing list