[FFmpeg-devel] [PATCH] Enables parsing DVD color palette directly from IFO file
michaelni at gmx.at
Sat Nov 15 12:51:47 CET 2014
On Sat, Nov 15, 2014 at 01:34:29PM +0900, TOYAMA Shin-ichi wrote:
> Thank you for discussing about this.
> Michael Niedermayer wrote in <20141114203251.GX32286 at nb4>
> >> + ctx->has_palette = 0;
> >> + ret = avio_open2(&ifo, p, AVIO_FLAG_READ, NULL, NULL);
> >libavcodec does not depend on libavformat, thus libavcodec cannot
> >use avio_* directly. I should have realized/mentioned this when
> >suggesting avio
> I understood using avio-* stuffs breaks independency of
> libavcodec. Thanks for pointing it out.
> Nicolas George wrote in <20141114224120.GA3820 at phare.normalesup.org>
> >Le quartidi 24 brumaire, an CCXXIII, Michael Niedermayer a écrit :
> >> libavformat OTOH could read the IFO file with avio_open2/avio_read
> >> into extradata or some newly added ifo specific side data
> >> and dvdsubdec.c could then parse the palette out of that.
> >That would work. It can be even reasonably simple: dvdsubdec already accepts
> >extradata with the Vobsub IDX syntax (the same way it is stored as codec
> >private data in Matroska). Unless I am mistaken, it would suffice to use a
> >BPrint buffer to write "palette: XXXXXX,XXXXXX..." and use
> >avpriv_bprint_to_extradata() afterwards.
> >OTOH, if Shin-ichi is not motivated to change the patch once again, I
> >believe the version with fopen() is acceptable if marked experimental /
> >temporary in the docs.
> I hope I could do this in more proper way. But I'm quite new to
> inside ffmepg and my skill is immature. In addition, I have not
> enough spare time for this currently. I would like to learn more
> inside ffmpeg and look into how to use extradata method when I
> have time.
> Anyway, I revised the last patch using fopen() again and also
> marked it experimental in `decoders.texi'. Please review it and
> merge it if acceptable.
> I really appreceatate many help from you all. Thanks!
> TOYAMA Shin-ichi mailto:shin1 at wmail.plala.or.jp
> doc/decoders.texi | 4 +++
> libavcodec/dvdsubdec.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++++
> libavcodec/version.h | 2 -
> 3 files changed, 61 insertions(+), 1 deletion(-)
> 8f677ab98ba2910ebca2ae638bbc5e86ab4fa0d8 0001-New-option-for-obtaining-global-palette-from-.IFO-fi.patch
> From e3743582c865949f8fe8b5a317a55a181380aedc Mon Sep 17 00:00:00 2001
> From: Shin-ichi Toyama <shin1 at wmail.plala.or.jp>
> Date: Sat, 15 Nov 2014 12:42:30 +0900
> Subject: [PATCH] New option for obtaining global palette from .IFO file
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 181 bytes
Desc: Digital signature
More information about the ffmpeg-devel