[FFmpeg-devel] [PATCH 4/4] web/style.less: Separate out .table-bordered from .table
timothygu99 at gmail.com
Sun Nov 16 00:49:56 CET 2014
On Sat, Nov 15, 2014 at 3:45 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Fri, Nov 14, 2014 at 05:12:47PM -0800, Timothy Gu wrote:
>> On Thursday, November 6, 2014, Timothy Gu <timothygu99 at gmail.com> wrote:
>> > The only instance of .table in the web source is the download page for the
>> > Git repos. I did not change that page because an unbordered table there is
>> > prettier IMO.
>> > I retained the .table-bordered style in case anyone want to use it in the
>> > future.
>> > Signed-off-by: Timothy Gu <timothygu99 at gmail.com>
>> > ---
>> > src/less/style.less | 61 ++++++++++++++++++++++++++++++++++++++++++++++-------
>> > 1 file changed, 53 insertions(+), 8 deletions(-)
>> Before-after comparison: http://imgur.com/eXSXFxe&tjnkmXb
> which way do people prefer ?
> please comment
> ill apply it if more people like the look after the patch then before
> its not clear to me which way is/looks better
The main reason for this patch is because in fateserver-node I
redesigned the build result page to utilize this borderless design,
but that requires a change to the style.less file. When I wrote the
patch I initially wanted to retain the old style for all the pages
that uses .table, but it seems like the only page that uses it does
not look worse without borders.
If the bordered design is what people prefer I can send a new patch
that splits the styles **and** retains the old style.
More information about the ffmpeg-devel