[FFmpeg-devel] [PATCH 08/11] ffserver: export recommented encoder configuration

[Lukasz Marek]

On 18.11.2014 22:50, Reynaldo H. Verdejo Pinochet wrote:
> Hi
>
> On 11/16/2014 10:46 PM, Lukasz Marek wrote:
>> [..]
>> @@ -3355,6 +3354,9 @@ static int add_av_stream(FFServerStream *feed, AVStream *st)
>>       fst = add_av_stream1(feed, av, 0);
>>       if (!fst)
>>           return -1;
>> +    if (av_stream_get_recommended_encoder_configuration(st))
>> +        av_stream_set_recommended_encoder_configuration(fst,
>> +            av_strdup(av_stream_get_recommended_encoder_configuration(st)));
>
> Is the return of av_strdup here been freed somewhere?. Also
> adding braces to ifs when the body is multilined wouldn't
> hurt. Not a blocker of course.
>
> Looks OK otherwise. Feel free to push after confirming ^
>
> Bests,
>

Updated patch, av_dict_serialize -> av_dict_get string

I think I have resent all modified patches, but
I pushed whole patchset to my github master branch just in case.
https://github.com/lukaszmluki/ffmpeg


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-ffserver-export-recommented-encoder-configuration.patch
Type: text/x-patch
Size: 6801 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141122/3d2cf506/attachment.bin>