[FFmpeg-devel] [PATCH 4/7] avcodec/ass: output missing fields in AVSubtitles and output files

[Clément Bœsch]

On Tue, Oct 14, 2014 at 08:35:51PM +0200, James Darnley wrote:
> On 2014-10-11 19:59, Clément Bœsch wrote:
> > Fixes Ticket #3207
> > ---
> >  libavcodec/ass.c                |  29 +++++++++--
> >  libavcodec/version.h            |   2 +-
> >  tests/ref/fate/sub-aqtitle      |  72 +++++++++++++--------------
> >  tests/ref/fate/sub-charenc      | 106 ++++++++++++++++++++--------------------
> >  tests/ref/fate/sub-jacosub      |  28 +++++------
> >  tests/ref/fate/sub-microdvd     |  28 +++++------
> >  tests/ref/fate/sub-movtext      |  12 ++---
> >  tests/ref/fate/sub-mpl2         |  14 +++---
> >  tests/ref/fate/sub-mpsub        |  48 +++++++++---------
> >  tests/ref/fate/sub-mpsub-frames |  10 ++--
> >  tests/ref/fate/sub-pjs          |  12 ++---
> >  tests/ref/fate/sub-realtext     |  16 +++---
> >  tests/ref/fate/sub-sami         |  24 ++++-----
> >  tests/ref/fate/sub-srt          |  80 +++++++++++++++---------------
> >  tests/ref/fate/sub-subviewer    |  12 ++---
> >  tests/ref/fate/sub-subviewer1   |  26 +++++-----
> >  tests/ref/fate/sub-vplayer      |  12 ++---
> >  tests/ref/fate/sub-webvtt       |  36 +++++++-------
> >  18 files changed, 294 insertions(+), 273 deletions(-)
> 
> These test filetypes are input files, right?  And you're encoding to
> SSA/ASS, right?  The output certainly looks like SSA.  I'm just checking
> that these changes are not unrelated.
> 

Yes, it tests the input format/codecs subtitles: the subtitles decoders
output ASS for the markup, the "encoding" and muxing to ASS/SSA is as a
result (almost) a no-op (it's a bit equivalent to a rawvideo in .y4m for
video).

It's basically to test if the demuxers and decoders output proper markup
and timestamps, ASS is the most obvious output to test that.

> Other than that it looks fine and seems to agree with what's in the ticket.
> 

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141014/bb02d2d9/attachment.asc>