[FFmpeg-devel] [PATCH 1/4] ffserver: move configuration code to separate file

Stefano Sabatini stefasab at gmail.com
Tue Oct 21 15:40:54 CEST 2014

On date Tuesday 2014-10-21 13:18:01 +0200, Lukasz Marek encoded:
> On 21 October 2014 12:08, Stefano Sabatini <stefasab at gmail.com> wrote:
> > On date Monday 2014-10-20 23:56:59 +0200, Lukasz Marek encoded:
> > > This commit doesn't change any existing logic.
> > > It moves ffserver configuration related code to separate file.
> > > It intends to make maintaining easier.
> >
> > I'm not opposed, but please tell why you think it's better this way. I
> > still hate the ffmpeg.c/ffmpeg_opt.c split, since it makes debugging
> > and browsing the code much harder for me, also it increases the
> > complexity since you have to declare otherwise static functions.

> ffserver.c has almost 5k lines now. The Commit moves 1k to separate file
> and there are only 2 calls in ffserver.c to moved code now.
> Is it a matter of personal preferences, but handling 5k lines file is not
> easy in general I think.
> Especially when there is still some work to be done in parsing code so it
> will grow a bit probably.

I'm fine with whatever the maintainer will decide.
FFmpeg = Faithful Frightening Majestic Ponderous Extreme Guru

More information about the ffmpeg-devel mailing list