[FFmpeg-devel] [PATCH] Use v4l2 input format automatically if filename starts with "/dev/video"

Nicolas George george at nsup.org
Sat Oct 25 11:43:12 CEST 2014

Le tridi 3 brumaire, an CCXXIII, Timothy Gu a écrit :
> Those URLs are very explicit, while `/dev/` can mean anything,
> including `/dev/stdin`.

Andrey quoted these bits of code to show that checking filename for NULL is
not necessary. I believe his proof is conclusive for that point.

wm4 :
> IMHO it should check whether it's really a video device.

Yes, it should. Do you intend to propose the patch that invokes stat() on
all supported operating systems, check that can not devolve into a security
issue in the context of probing, find the relevant list of major/minor
pairs and a way of testing the dynamically allocated ones soon, or are you
just bikeshedding.

Because if you are just bikeshedding, I believe the patch with a lower
score, EXTENSION instead of MAX maybe, would be fine.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141025/cee3b40c/attachment.asc>

More information about the ffmpeg-devel mailing list